Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interaction during screen transitions [WPB-6533] 🍒 🍒 #3182

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 15, 2024

BugWPB-6533 [Android] During transition between 2 screens both screens are clickable

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The user can click on a screen during the transition, for instance when the screen is being closed, it's still clickable so if user clicks during closing, it can still open something from the previous screen and end up on a different screen than user wanted.

Causes (Optional)

The screen during transition is still clickable and can interact until it's fully hidden.

Solutions

Create a wrapper WaitUntilTransitionEndsWrapper for the destination composables so that it covers the entire screen and intercepts any click. This cover is added to the screen only when the transition is ongoing, at the moment the transition ends, this cover is removed from the screen so that it's fully clickable.
Created new annotation @WireDestination which replaces @Destination and contains this wrapper by default.

Testing

How to Test

Navigate in the app and try to quickly click on the screen that's being open or closed.

Attachments (Optional)

Transition animations were slowed down to 2s in videos below.

Before After
before.mp4
after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/M labels Jul 15, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 15, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 15, 2024
Copy link

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3182.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3182.apk is available for download

@saleniuk saleniuk requested review from a team, yamilmedina, mchenani, Garzas, ohassine and saleniuk and removed request for a team July 15, 2024 14:02
@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 15, 2024
Merged via the queue into develop with commit 79c6a03 Jul 15, 2024
12 checks passed
@MohamadJaara MohamadJaara deleted the fix/clicks-during-screen-transition-cherry-pick-cherry-pick branch July 15, 2024 16:45
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants